Skip to content

Fix build 💚 #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

Fix build 💚 #215

merged 2 commits into from
Oct 29, 2024

Conversation

chubchenko
Copy link
Contributor

@chubchenko chubchenko commented Oct 29, 2024 •
edited
Loading

  • Use Rack::Response#headers instead of Rack::Response#header. header is deprecated and removed in version 3.1.
  • Add support for testing with multiple versions of Rack (2 and 3)

@chubchenko chubchenko marked this pull request as ready for review October 29, 2024 13:03
@jsmestad jsmestad merged commit 67f5ba6 into wardencommunity:master Oct 29, 2024
14 checks passed
@jsmestad
Copy link
Collaborator

Thanks!

@jsmestad jsmestad self-assigned this Oct 29, 2024
@chubchenko chubchenko deleted the fix-build branch October 30, 2024 07:07
@fnordfish fnordfish mentioned this pull request Aug 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jsmestad jsmestad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chubchenko @jsmestad