Work with next release of Twisted, and run tests on Python 3.13 #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
meejah
approved these changes
Sep 4, 2024
| self.fail("didn't see invocation of callRemote in stacktrace") | ||
| d.addCallbacks(lambda res: self.fail("hey, this was supposed to fail"), | ||
| _check_failure) | ||
| return d |
There was a problem hiding this comment.
This is removed because test_logging now covers it with the new assert?
|
|
||
| [testenv] | ||
| passenv = USERPROFILE HOMEDRIVE HOMEPATH PYTHONWARNINGS | ||
| passenv = USERPROFILE,HOMEDRIVE,HOMEPATH,PYTHONWARNINGS |
There was a problem hiding this comment.
Oh yeah, this one was "fun" ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next release of Twisted will have different tracebacks in Failures (omitting the stack of Failure creation).