Repository navigation
Restore native local child owners in resumed cloud parent drivers - #16557
Draft
warp-agent-staging[bot] wants to merge 6 commits into
Draft
warp-agent-staging[bot] wants to merge 6 commits into
warp-agent-staging[bot] wants to merge 6 commits into
Conversation
Contributor
Author
|
This PR was generated with Warp. Comment |
…local-child-handoff # Conflicts: # app/src/ai/agent_sdk/driver.rs # app/src/ai/agent_sdk/driver/terminal.rs
Contributor
Author
There was a problem hiding this comment.
Overview
The paired drafts restore native local child owners and gate inbox delivery on transcript hydration. Required headless integration proof is still missing.
Concerns
- Important — required integration proof is incomplete.
specs/QUALITY-2186/TECH.mdrequires VM A→B restoration, a real wake→replay→child turn, and pagination/skip-initial-turn barriers; the passing component tests do not exercise these paths. Which disposable paired client/server environment should run that proof before these drafts are treated as ready?
Verdict
Checks: build pass, component tests pass, CI red (draft gate intentionally skips build/test jobs), visual proof n/a (declined).
Found: 0 critical, 1 important, 0 suggestions, 0 nits. Integration environment/proof decision required; no approval or denial submitted.
Responding as eng-factory-slim: Open session · View in factory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Restore native/Oz local child owners inside a resumed cloud parent’s existing agent-driver process. Strict paginated discovery completes before parent execution; each eligible child gets a hidden owner and its own wake listener without fetching its transcript eagerly.
A wake or pane open coalesces transcript hydration into the existing conversation ID. Normal inbox delivery stays gated until installation succeeds; setup or hydration failure marks that child Error. Desktop and Observer discovery stays passive for cloud-owned parents.
Review order: the approved contract in
specs/QUALITY-2186/TECH.md, shared discovery, headless owner bootstrap, then the streamer/controller hydration gate and passive seeding. Ownership uses the existing PaneGroup rather than a new workspace. Existing parent handoff/credential safeguards apply; no additional physical-VM teardown barrier is introduced.Companion server: https://github.com/warpdotdev/warp-server/pull/20288. Deploy it before enabling the default-off
RestoreLocalChildOwnersflag in any environment; an older server’s valid-but-wrong location cannot be detected by this client.Linked Issue
QUALITY-2186
ready-to-specorready-to-implement. This is a Linear issue; the GitHub issue label does not apply.Testing
Passed before final formatting:
cargo nextest run -p warp --lib -E 'test(restored_local_child_)': 9 cases covering strict traversal/decoding, classification, passive Observer seed/cursor, owner promotion, hydration coalescing, and transcript Error handling.env -u WARP_WORKLOAD_TOKEN WARP_ISOLATION_PLATFORM=dockerto avoid unavailable Namespace token issuance in this sandbox.cargo check -p warpandcargo clippy -p warp --all-targets --tests -- -D warnings.Outstanding approved-spec validation: no live VM A→B handoff or actual wake→replay→child message-turn run was exercised. Component tests do not prove a driver-level pagination barrier before initial or
--skip-initial-turnexecution, successful post-hydration replay/turn, or every failure-stage variant. These drafts remain blocked pending that proof; this is not a fully validated handoff../script/run. Not run; UI verification was declined. The headless cross-VM/message path still needs integration proof.Agent Mode
Plans: