Package tooling reorganization and README.md cleanup #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this branch
Include a description of changes introduced on branch here
Verify
Confirm that cross browser testing has been completed.
Verify that no errors are present in the GPT console
window.googletag.openConsole()
.Comments
I changed/cleaned a bunch of this codebase to make it more maintainable. Most of the changes in this PR are from properly reconfiguring ESLint.
Minor changes/fixes:
esdoc
,esdoc-standard-plugin
, andpromise-polyfill
. These were exclusively getting used as dev dependencies so I moved them there.package-lock.json
as well as aYarn.lock
which were out of sync with each other. The beginning of the README mentioned using NPM, while Yarn was mentioned more near the end. I saw no reason to use Yarn so I removed theYarn.lock
and updated thepackage-lock.json
.testURL
and upgrade Jest to get the tests to run.dist
directory wasn't in our.gitignore
.Webpack changes:
@babel/plugin-transform-runtime
and usescore-js
polyfills. The UMD bundle uses@babel/preset-env
withcore-js
polyfills.promise-polyfill
wasn't being used anyway so I uninstalled it. It's been replaced withcore-js
Promises.babel-core
and updated@babel/core
.(This is a draft PR because rigorous cross-browser testing is still needed.)
(Also, I would release this as a major update.)