This repository was archived by the owner on Jun 10, 2024. It is now read-only.
use call_actor callback for better reusability of library#207
Merged
Conversation
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Contributor
Author
|
Dependent on wasmCloud/wasmcloud-test#24, which is in turn dependent on wasmCloud/weld#143 |
Signed-off-by: stevelr <steve@cosmonic.com>
Contributor
Author
|
Contributor
Author
|
Other than references in Cargo.toml (which will be changed when dependent PRs are merged), this is ready for review |
stevelr
requested review from
autodidaddict and
brooksmtownsend
as code owners
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Contributor
Author
|
blocked on wasmCloud/wasmcloud-test#24 |
Signed-off-by: stevelr <steve@cosmonic.com>
brooksmtownsend
previously requested changes
Feb 28, 2023
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
Member
brooksmtownsend
left a comment
brooksmtownsend
left a comment
There was a problem hiding this comment.
LGTM once git dependencies are pinned dependencies
Signed-off-by: stevelr <steve@cosmonic.com>
Contributor
Author
|
Note: after this PR is merged, tag and release wasmcloud-httpserver-provider library as a new crate |
Signed-off-by: stevelr <steve@cosmonic.com>
brooksmtownsend
approved these changes
Mar 24, 2023
Signed-off-by: stevelr <steve@cosmonic.com>
Signed-off-by: stevelr <steve@cosmonic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the functionality of the httpserver capability provider is wrapped in a library wasmcloud-provider-httpserver, which was intended to provide a reusable, embeddable http server library.
This change improves the reusability of the library by allowing customization of
call_actor: the asynchronous function that delivers the http payload to an actor, waits for the result, and returns the response to the http caller.With this change, the http server can use different transports to communicate with the actor, for example, by sending the http payload over nats, instead of wasmbus-rpc.
The wasmcloud-provider-httpserver library has not yet been published to crates.io. We'd like to publish it as a crate after this PR is merged.