Conversation
A custom resolver was introduced in 6c68235, which does not seem to be necessary, since the crate builds just fine without it and is inconsistent with other providers Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
requested review from
autodidaddict,
brooksmtownsend and
stevelr
as code owners
rvolosatovs
force-pushed
the
build/workspace
branch
from
9a0d8f1 to
859c146
Compare
Introduce a workspace to simplify maintenance, speed up builds by faciliating artifact reuse and minimize dependency graph (and make it consistent) Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Add symlinks to workspace `target` until wasmCloud/wasmcloud-test#22 is merged and integrated into this repository removing the need for on-disk test configuration Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
|
My only concern is the symbolic links in the target folders. I would rather fix the makefiles and other things than use symlinks and potentially cause problems with portability/windows. |
I agree with the concern, however note that the symlinks are removed in #219. If wasmCloud/wasmcloud-test#22 were to be merged and a new version of the crate was released, I could cherry-pick that commit here and there'd be no need for symlinks in |
|
okay. I was just looking at this PR in isolation so I didn't know that the symlinks were being removed. |
see also commit message 859c146 |
Thanks for pointing that out. When I use the review button in Github, I don't see commit mesages. |
brooksmtownsend
left a comment
brooksmtownsend
left a comment
There was a problem hiding this comment.
Looks great, I was concerned this would force us to compile the entire repo for a single provider but that doesn't seem to be the case.
@rvolosatovs Just to be sure, have you attempted to run make par-full in these new directories? I think you will need to add the workspace as a volume in order for the build to resolve the dependency versions. This is a check we run on-release so it might not be caught with our build CI
|
@rvolosatovs if you wouldn't mind rebasing and checking out my last comment, I think we can merge this in. Just need to get that addressed |
Since we're moving these to |
3 participants
Feature or Problem
Introduce a workspace to simplify maintenance, speed up builds by
facilitating artifact reuse and minimize dependency graph (and make it
consistent)
Note, a custom resolver introduced in 6c68235 does not seem to be
necessary, since the crate builds just fine without it and is inconsistent with other providers.
Removed to make things simpler with the workspace
Related Issues
wasmCloud/wasmcloud-test#22
Release Information
Consumer Impact
Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
Built locally and tested in CI