This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
feat(*) wash burrito support #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
force-pushed
the
feat/wash-burritos
branch
2 times, most recently
from
5af671e to
fa2bbba
Compare
brooksmtownsend
commented
May 17, 2023
Comment on lines
+8
to
+9
| [lib] | ||
| crate-type = ["cdylib", "rlib"] |
There was a problem hiding this comment.
note: this change to the test artifact lets people run cargo install --git <this repo> again. cargo was picking this crate up as a binary you could install
brooksmtownsend
force-pushed
the
feat/wash-burritos
branch
from
fa2bbba to
071a921
Compare
This was referenced May 17, 2023
brooksmtownsend
commented
May 22, 2023
brooksmtownsend
commented
May 22, 2023
Comment on lines
160
to
170
| // NOTE(brooksmtownsend): This seems like a lot of work when I really just want to use AsyncRead | ||
| // to pipe the response body into a file. I'm not sure if there's a better way to do this. | ||
| let download_response = reqwest::get(url.clone()).await?; | ||
| if download_response.status() != StatusCode::OK { | ||
| return Err(anyhow!( | ||
| "Failed to download wasmCloud host from {}. Status code: {}", | ||
| url, | ||
| download_response.status() | ||
| )); | ||
| } | ||
| let wasmcloud_host_burrito = reqwest::get(url).await?.bytes().await?.to_vec(); |
There was a problem hiding this comment.
@thomastaylor312 Line 170 is the one that feels weird, in tandem with having to copy it with .as_slice()
brooksmtownsend
requested review from
autodidaddict and
thomastaylor312
as code owners
brooksmtownsend
force-pushed
the
feat/wash-burritos
branch
from
c752762 to
1318296
Compare
connorsmith256
suggested changes
Jun 5, 2023
brooksmtownsend
force-pushed
the
feat/wash-burritos
branch
3 times, most recently
from
c3c30c3 to
91751c8
Compare
connorsmith256
previously approved these changes
Jun 9, 2023
brooksmtownsend
force-pushed
the
feat/wash-burritos
branch
from
91751c8 to
c800d36
Compare
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]> cleanup TODOs, satisfy clippy Signed-off-by: Brooks Townsend <[email protected]> addressed test failures Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]> v2 Signed-off-by: Brooks Townsend <[email protected]> same port fail Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/wash-burritos
branch
from
c800d36 to
790d357
Compare
Signed-off-by: Brooks Townsend <[email protected]> un-re-de-comment integration build Signed-off-by: Brooks Townsend <[email protected]> removed test debugs Signed-off-by: Brooks Townsend <[email protected]> removed moar printlns Signed-off-by: Brooks Townsend <[email protected]> cfg idk Signed-off-by: Brooks Townsend <[email protected]> sleepy Signed-off-by: Brooks Townsend <[email protected]> sleepy Signed-off-by: Brooks Townsend <[email protected]> added debug info to failing test Signed-off-by: Brooks Townsend <[email protected]> removed kill-on-drop logic Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
feat/wash-burritos
branch
from
e58e2b9 to
854404d
Compare
thomastaylor312
suggested changes
Jun 12, 2023
Signed-off-by: Brooks Townsend <[email protected]>
thomastaylor312
approved these changes
Jun 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Problem
This PR adds support for running wasmCloud/wasmcloud-otp#616 artifacts (burrito releases) with
wash up. This will be a significant breaking change and will bump the minimum wasmCloud version thatwashcan manage from0.57.1(when we stopped using distillery) to0.63.0.PR action items:
wash upwash downmaintenance uninstallto thewash draincommand (I think this can be done in a separate PR since burritos auto-upgrade)Related Issues
Fixes #464 after pulling in implementation from #527
Fixed #492
Release Information
washv0.18.0wash-libv0.9.0?? We may need to hold on merging this PR until we can release 0.18 as scheduledChanged to v0.18.0 as it makes sense to release this with wadm
Consumer Impact
Consumers won't notice a difference with running the wasmCloud host, only that the downloaded assets are a single binary
wasmcloud_hostinstead of a tarball-ed directoryTesting
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
As of creation, I've run
cargo run -- upandcargo run -- up -dwhich worked great.downnow works by using NATS to tell hosts to stop instead of executing themix release, and I've verified that a variety of scenarios work well.