Skip to content

Commit

Permalink
ci: only build Docker images on tag pushes
Browse files Browse the repository at this point in the history
We should be testing this always, not only on tag pushes

Signed-off-by: Roman Volosatovs <[email protected]>
  • Loading branch information
rvolosatovs committed May 8, 2023
1 parent 5d531e3 commit 82dc903
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,13 @@ jobs:
Taskkill /im wasmcloud_host_x86_64_windows.exe /f
release:
# TODO: Build on PRs and pushes to main (but do not push)
# This is currently blocked on the `app-version` computation, which only supports semver tags
# E.g.:
# ```
# Error: buildx failed with: ERROR: invalid tag "wasmcloud.azurecr.io/wasmcloud_host:616/merge": invalid reference format
# ```
if: startswith(github.ref, 'refs/tags/') # Only run on tag push
strategy:
matrix:
config:
Expand Down

0 comments on commit 82dc903

Please sign in to comment.