Draft
Conversation
- Replace the free-form `TomlMap` by a structured, typed `Config` struct - Remove `bin_path` from config - Require passing of `Config` and `bin_path` to `test_provider` at runtime Breaking changes: - `load_config` is replaced by `Config::load` method - `test_provider` requires `bin_path` and `Config` as arguments - `rust_backtrace` config field is renamed to `backtrace` and it's type is changed from string to a boolean Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Contributor
|
A lot of these changes seem to have been merged into #22 - if there are just a few remaining, you could add them to pr 22 and close this, or we could wait till 22 is merged and then rebase this. your choice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #22 to keep the diff small and avoid scope creep