Merge with spec, function-references, and gc #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YiYing He <[email protected]>
[test] Prevent from module name conflict when registering in wast.
Fix formatting in the spec binary section for table initializers
[spec] Fix spec for execution of `struct.new`, `array.new_fixed` and `br_on_cast(_fail)`
[spec] Fix typing of functions
[spec] Fix prose for blocktype validation
Signed-off-by: YiYing He <[email protected]>
[spec] fix immediate of `array.set` instruction.
Add missing backslash on \LTYPE
Local validation doesn't need `ok`
Locals in a function have structure so need {type t} to
match the valtype
Fix a few minor issues in local validation rules
Fix `array.get/set` reduction rule
Pass index argument to `getfield` function
Co-authored-by: Andreas Rossberg <[email protected]>
Co-authored-by: Andreas Rossberg <[email protected]>
chore(doc): fix some typos
The underscore needs to be escaped.
…tting [spec] Fix formatting of any.convert_extern and extern.convert_any
Minor changes on array.new_elem
[spec] Tweak dimensionality in array.new_data
`ref null` is currently how nullable references are specified in the typed references spec
That instruction as removed in WebAssembly/function-references#63
…encies Fix Overview.md inconsistencies
remove duplicated token definition in parser
The global.get instruction can refer to previously defined globals in addition to imported ones now. Uses of global.get in data and element segments can refer to any global.
This avoids having two binary encoding errors which makes testing that a parser caught the expected error difficult.
[spec] Update global.get note on constant expressions
Fix off-by-one length in `binary-gc.wast`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch pulls in the recent changes to WebAssembly/spec, WebAssembly/function-references, and WebAssembly/gc.