Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert mangle-symbols feature #1316

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

xdoardo
Copy link
Contributor

@xdoardo xdoardo commented Nov 27, 2024

As discussed in #1315.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.57%. Comparing base (37a8116) to head (f4fc8c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
- Coverage   81.58%   81.57%   -0.01%     
==========================================
  Files         306      306              
  Lines       25271    25271              
==========================================
- Hits        20617    20616       -1     
- Misses       4654     4655       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xdoardo xdoardo force-pushed the revert-mangle-symbols branch from 9ce88ee to ee84df1 Compare November 27, 2024 09:44
@Robbepop
Copy link
Member

Robbepop commented Nov 27, 2024

@xdoardo This PR does not really revert [the original PR)[https://github.com//pull/1312].

Would you be so kind and reset your branch and simply use Git's very own git revert command in order to revert the squashed commit of the PR and then force push this PR?

git revert 37a8116eb6672c027e44623dc4c02c2415e41ecc

Using this command makes sure there are no mistakes since it is fully automated.

@xdoardo xdoardo force-pushed the revert-mangle-symbols branch from ee84df1 to f4fc8c0 Compare November 27, 2024 10:06
Copy link
Member

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Robbepop Robbepop merged commit 8cc0258 into wasmi-labs:main Nov 27, 2024
19 checks passed
@xdoardo xdoardo deleted the revert-mangle-symbols branch November 27, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants