Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react-dom and react-router-dom deps validation #2445

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Add react-dom and react-router-dom deps validation #2445

merged 3 commits into from
Jan 13, 2025

Conversation

infomiho
Copy link
Contributor

Adds validation for user's package.json for react-dom and react-router-dom and updates the example apps.

Closes #2408

@infomiho infomiho requested a review from sodic January 13, 2025 12:53
sodic
sodic approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sodic sodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Should this go into the changelog? And should we mention it in the migration guide (if we're gonna have one)?

@infomiho
Copy link
Contributor Author

Yes and yes 👍 I've settled on doing the Changelog and migration docs in one go.

@infomiho infomiho merged commit 8a1a38c into main Jan 13, 2025
6 checks passed
@infomiho infomiho deleted the miho-user-package-json-deps branch January 13, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodic sodic sodic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add react-dom and react-router-dom deps to the user's package.json
2 participants
@infomiho @sodic