Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart improvements (PodDisruptionBudget and topologySpreadConstraints) #148

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Helm chart improvements (PodDisruptionBudget and topologySpreadConstraints) #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f5d59a
bump chart version to v2
jabdoa2 Apr 26, 2024
3b0efd4
support topology spread constraints in chart
jabdoa2 Apr 26, 2024
bd3999d
add pod disruption budgets to chart
jabdoa2 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/wave/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
apiVersion: v1
apiVersion: v2
name: wave
description: wave chart that runs on kubernetes
version: 3.0.0
Expand Down
1 change: 1 addition & 0 deletions charts/wave/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,5 @@ spec:
nodeSelector: {{ toYaml .Values.nodeSelector | nindent 8 }}
affinity: {{ toYaml .Values.affinity | nindent 8 }}
tolerations: {{ toYaml .Values.tolerations | nindent 8 }}
topologySpreadConstraints: {{ toYaml .Values.topologySpreadConstraints | nindent 8 }}
volumes: {{ toYaml .Values.extraVolumes | nindent 8 }}
12 changes: 12 additions & 0 deletions charts/wave/templates/poddisruptionbudget.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{{- if .Values.pdb.enabled }}
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
name: {{ include "wave-fullname" . }}
namespace: {{ .Release.Namespace }}
spec:
selector:
matchLabels:
{{ include "wave.selectorLabels" . | nindent 6}}
maxUnavailable: 1
{{- end }}
10 changes: 10 additions & 0 deletions charts/wave/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ nodeSelector: {}
# Replicas > 1 will enable leader election
replicas: 1

# Add PodDisruptionBudget which should be enabled for replicas > 1
pdb:
enabled: false

# Additional volumes to use in the pod.
extraVolumes: []
# - name: tmp
Expand Down Expand Up @@ -58,8 +62,14 @@ resources: {}
# cpu: 100m
# memory: 128Mi

# node tolerations for wave pod
tolerations: []

# (anti-)affinity for wave pods
affinity: {}

# topologySpreadConstraints for the wave pods
topologySpreadConstraints: []

# extra annotations for wave pods
podAnnotations: {}
Loading