Update ginkgo #149
Merged
Update ginkgo #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jabdoa2
commented
Apr 26, 2024
•
jabdoa2
commented
- Download and setup golangci-lint in Makefile if needed
- Update and simplify CONTRIBUTING.md
- Update project to ginkgo/v2 (same version as our dependencies are using)
- Remove custom xunit reporter as we do not use it anywhere and ginkgo/v2 also supports that out of the box via commandline parameters
toelke
previously approved these changes
Apr 29, 2024
those are currently unused and ginkgo v2 supports xunit out of the box via commandline parameters
toelke
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.