Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle projections #152

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Handle projections #152

merged 2 commits into from
Apr 29, 2024

Conversation

jabdoa2
Copy link
Contributor

@jabdoa2 jabdoa2 commented Apr 27, 2024

Fix #127 by implementing it.

PR is on top of #151 to prevent merge conflicts. Let me know if you want me to rebase it.

@jabdoa2 jabdoa2 requested a review from a team as a code owner April 27, 2024 19:23
Copy link
Collaborator

@toelke toelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge #151 first, then rebase this, and only then merge this.

@jabdoa2
Copy link
Contributor Author

jabdoa2 commented Apr 29, 2024

Let's merge #151 first, then rebase this, and only then merge this.

When do you plan to merge this? I cannot click merge as I do not have write permissions.

@toelke
Copy link
Collaborator

toelke commented Apr 29, 2024

Oh, sorry. I did not realize. At work we are used to approving a PR and let the author merge. This will not work here, of course :-D

@toelke toelke merged commit 9f93638 into wave-k8s:master Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changes to projected volumes not detected properly
2 participants