allow to only watch certain namespaces #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for all the contributions. I had a brief look at this, but I think I will only have enough time to understand this and all the repercussions next week. :-( |
Yeah don't worry. We are not in a hurry at all. |
toelke
force-pushed
the
limiting_namespaces
branch
from
215c363
to
2fc50c8
Compare
toelke
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #37. Superseeds #92.
I tried writing a proper test for this but failed. I can change one of the controller tests to use the correct namespace and they will pass. However, I failed to do both (a) watch all namespaces and (b) for a separate test watch only some namespaces.