Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failover local file #24

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

remy56k
Copy link

@remy56k remy56k commented Dec 13, 2024

I have a working example for #23
If error (if WLG can not push QSO with success), the QSO is written in the specified file :

image

Import the resulting file with multiples QSO in the WaveLog web interface works fine.

Maybe we can improve/adapt GUI error messages when the QSO is logged in the file.

Test Ok on Ubuntu 22, cannot check on Windows atm.

@remy56k remy56k force-pushed the failover_local_file branch from 64cd599 to 8b14aa2 Compare December 13, 2024 21:34
Copy link
Contributor

@int2001 int2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the PR itself:

i think the Window needs a bit more height. Otherwise it looks crappy.

Generally:

I am still not a real friend of that feature. I like WavelogGate to be simple. Very simple. I've currently many support issues with it, because there are hams out there who are not able to use WSJT-X, FLRig and WLGate in that simple way. Thats sad for a technical hobby, but true. People will ask over and over about that "Failover ADIF File" where WSJT-X produces its own file which can easily be uploaded with dupe-check enabled.

tbh: i am not sure how to deal with your PR. You invested effort. The use-case is covered by WSJT-X itself. it brings more complexity into a small UI/Tool (For me no problem, but i am thinking about the normal, overwhelmed ham).
Open for ideas. Currently in my mind:

  • expert version? (But where should we put it?)
  • Commandline-switch for advanced features?
  • Dropdown-Menu for those settings?

@int2001
Copy link
Contributor

int2001 commented Dec 31, 2024

A few more things besides my considerations above(sorry!).
What about:

  • checking if location exists? Otherwise the write would fail and the OP can't see it.
  • a "folder-requester" modal where one can chose the path? (Should be doable with internal functions)

i learned from Wavelog itself: Everything needs to be bulletproof, because people are doing the wildest things...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants