Add snapshot storage #1215
Merged
Add snapshot storage #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…shot.IssuerPublicKey'.
* Replaced current recording to storage to snapshot applier * Replaced to snapshot applier, except balances * Fixed a comment * Removed the comment * Removed unnecessary code * Returned the linter command back * Added asset script atomic snapshot to the issue script actions * Fixed some linter issues * Fixed a few more linter issues * Fixed all linter issues * Fixed err shadowing * Fixed a mistake with issue counter * removed a useless line * Fixed applying order transactions * Fixed applying order transactions * Added lising snapshot to the tx diff generated group * Moved complexity saving into transaction performer * Moved complexity saving into transaction performer * removed a line * Fixed a bug with an empty sender * Used error.Is * Set an empty script for issue with sig * move snapshots types to proto * Fixed a bug with wrong action sender * Fixed a bug with wrong action sender * Add 'TransactionStatusSnapshot'. * Implemented 'AtomicSnapshot' interface for 'TransactionStatusSnapshot'. * Changed 'AssetScriptSnapshot' and 'scriptStorageState.setAssetScript'. Removed 'pk' arg from 'setAssetScript'. Removed two fields from 'AssetScriptSnapshot': - 'SenderPK' - 'Complexity' * * Commented invoke snapshots, import ok * moved setting complexity and set script to snapshot applier * Fixed a test and a mistake * Fixed renaming * Fixed a comment * Moved dapp complexity to applier * Added dapp complexity to set script as well * Fixed a check mistake * Fixed a test * removed empty script check * removed a todo * Removed useless code * Modified a test * Fixed same keys issue for data entry actions * Remove invoke snapshot (#1235) * moved complexity back * Reverted some changes, import ok * Returned account script and asset script txs, import ? * Uncommented internal snapshot, import ok * Fixed height problem with issue action and issue tx, import NO * Issue action reverted * Added log and issueCounter for issue action * Commented invoke snapshots, import ok --------- Co-authored-by: Nikolay Eskov <[email protected]> --------- Co-authored-by: Anton Ilin <[email protected]> Co-authored-by: Nikolay Eskov <[email protected]>
nickeskov
changed the base branch from
replace-to-snapshot-applier
to
node-transactions-snapshots-types
Anton-Rampage
force-pushed
the
add-snapshots-starage
branch
from
2a9db1b to
149c81b
Compare
nickeskov
requested changes
Nov 16, 2023
nickeskov
reviewed
Nov 18, 2023
| ScriptBytes: s.Bytes, | ||
| ScriptText: base64.StdEncoding.EncodeToString(s.Bytes), | ||
| Complexity: int64(s.Complexity), | ||
| PublicKey: nil, |
There was a problem hiding this comment.
Why is that nil? Is it intended?
nickeskov
approved these changes
Nov 20, 2023
alexeykiselev
approved these changes
Nov 21, 2023
alexeykiselev
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.