Feature/fangfrisch extra defs #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add extra config variables to control fangfrisch usage - refactor use of str_to_bool to avoid repetition - running aws sync as subprocess - running fangfrisch as subprocess
uncompressed lambda zip was hitting size limit, maybe downgrading will shrink size
must still verify if extra virus definitions get pulled form S3 from bluesentry#112
- refactored upload function to extract core upload logic - using all filenames to upload to s3 - refactored core upload logic to throw errors when no such file or md5 matches happen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upstream PR: bluesentry#212