refactor: use trim_start_matches to remove tilde and at symbols
#239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @angelofallars would you mind reviewing this? If not, I'll do the needful. |
|
CC: @zubairmh |
Shinyzenith
approved these changes
Feb 28, 2024
|
I approve these changes from my end but Ideally I think we shouldn't improve the hand rolled parser anymore -- the transition to the grammar based solution would be much better. Lets see what zubair thinks 😄 |
InnocentZero
pushed a commit
to InnocentZero/swhkd
that referenced
this pull request
Mar 19, 2024
…ycrate#239) * refactor: use `trim_start_matches` to remove tilde and at symbols * lint: cargo clippy
InnocentZero
pushed a commit
to InnocentZero/swhkd
that referenced
this pull request
Mar 26, 2024
…ycrate#239) * refactor: use `trim_start_matches` to remove tilde and at symbols * lint: cargo clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
strip_atfunction to calltrim_start_matcheson a string to strip the@and~chars.strip_tildefunction.strip_atapplied ontoken_newintotokens_no_at. The values are used in the subsequent for loop and for building the modifiers vector.Tests are passing.