Fix: Added rfkill support as a feature flag #298
Conversation
|
Looks good, would you mind adding some relevant documentation for this flag too? |
|
The quoted commit seems to be gone. That's odd. |
It was accessible just a few days ago, was similar to this pr moved rfkill support to a feature flag. anyway should'nt be too important since the changes are identical |
|
Instead of NO_DEFAULT_FEATURES can we just make the flag |
I don't think we can have such flag without changing the features to no_rfkill_support but according to cargo book features are intended to be additive only, link. Otherwise we could add another feature which includes all features other than rfkill, called no_rfkill_sw_support but that would be redundant |
|
If they're additive can we add |
That would be identical to current changes, the core issues is We either add rfkill switch support by default (current approach), requiring arch users to pass --no-default followed by all other defaults they wish to have (As far as i can tell this is the only way to opt out of a default feature in cargo) Or we make support of rfkill switch disabled by default, making rfkill switch support opt out by default for all users. Or we just ignore the cargo guide, and go with NO_RFKILL_SW_SUPPORT. This should not cause any issues since no other crate uses swhkd as dependency 😅 I think just going with the third option would be cleanest for now |
|
Sounds good, I'm fine with approach 3 |
There was a problem hiding this comment.
@newtoallofthis123 Can you double check things before I go ahead with the merge?
Combines this commit commit and #254 .
works on arch linux with mediatek MT7921 wifi module.
wifi stops resting as expected with --no-default-features flags, although i am not able to test with a rfkill switch yet