Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vision os support #43

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Vision os support #43

merged 3 commits into from
Jan 18, 2024

Conversation

bdunay3
Copy link
Contributor

@bdunay3 bdunay3 commented Jan 18, 2024

Description

This PR simply enabled visionOS as a deployable target for VSM. This included making the following changes:

  • I had to bump the version of Swift we are using to 5.9 in order to get support for visionOS as a platform
  • Updated the Package manifest to include visionOS as a platform target
  • Bumped the version of Xcode CI uses up to Xcode 15.2 (required to enable testing on the visionOS simulator)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other: Enabled new platform to build on

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

Bill Dunay and others added 3 commits January 12, 2024 17:43
Added support for visionOS
fd541a5
@albertbori
Maintenance (#38)
5b67765 
* Updated testable combine publishers

* Fixed Swift 6 conflicting generic aliases warning

* Fixed Xcode 14.3 UI test bug

* Update CI macOS and Xcode versions

* build destination corrections

* tidy up ci devices

* Fix flaky tests

* Upgrade actions

* Temporarily™ disabled broken UI tests
Bumpped CI to use Xcode 15.2. Also enabled unit tests for the VisionO…
01b0df4 
…S test target
@albertbori albertbori merged commit 10dafb9 into main Jan 18, 2024
3 checks passed
@albertbori albertbori deleted the visionOS_support branch January 18, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albertbori albertbori albertbori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdunay3 @albertbori