Feature package locking#1243
Closed
lupa95 wants to merge 3 commits intowazuh:masterfrom
Closed
Conversation
jonhattan
approved these changes
Jul 8, 2024
jonhattan
left a comment
jonhattan
left a comment
There was a problem hiding this comment.
Looks good to me.
Instead of lock/unlock the package, an alternate approach could be to enable/disable the repo. In the case of apt it should be renaming the sources list file to .disabled or something. Perhaps this is preferred option to the wazuh team.
| when: | ||
| - ansible_os_family|lower == "redhat" | ||
| - "'wazuh-agent' in ansible_facts.packages" | ||
| - not ansible_facts.packages['wazuh-agent'][0]['version'].startswith(wazuh_agent_version) |
There was a problem hiding this comment.
This could be computed in a fact since it is used twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing the idempotency issue discussed in #1240.
Packages get version locked and unlocked when installing/updating them, rather than adding and removing the package repositories on each run.
Unfortunately, it requires a module from the community.general collection. I am not sure if you want to introduce this.