Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow spaces in current working directory on certificate generation #658

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Nicceboy
Copy link

@Nicceboy Nicceboy commented Apr 25, 2024

If the current working directory includes spaces (even if it should not...), the self-signed cert generation script will fail.

Added quotes for the variable use and also set -e to fail script fast on error.

@gecube
Copy link

gecube commented Sep 13, 2024

lgtm

@Nicceboy also please consider to switching of generating certificates with cert-manager #577

@gecube
Copy link

gecube commented Sep 13, 2024

Also I prefer "${DIR}" syntax over $DIR or even "$DIR"... and for all possible environment variables.
Probably we should pass the shell scripts through some kind of shell linter. No idea which one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants