Open
Conversation
cruelsmith
reviewed
Aug 9, 2022
poloz-lab
force-pushed
the
feature-542-wazuh-template-filebeat
branch
from
8db5b99 to
b9cf3b3
Compare
cruelsmith
approved these changes
Aug 11, 2022
Contributor
cruelsmith
left a comment
cruelsmith
left a comment
There was a problem hiding this comment.
LGTM from the puppet code side. Needs decision from the wazuh team is they want to maintain this template in this module or only in the wazuh/wazuh repo.
poloz-lab
force-pushed
the
feature-542-wazuh-template-filebeat
branch
from
b9cf3b3 to
f5f3b23
Compare
poloz-lab
force-pushed
the
feature-542-wazuh-template-filebeat
branch
from
f5f3b23 to
976f742
Compare
Readable for others, as in the [documentation](https://documentation.wazuh.com/current/installation-guide/wazuh-server/step-by-step.html#configuring-filebeat)
poloz-lab
force-pushed
the
feature-542-wazuh-template-filebeat
branch
from
976f742 to
4f06a43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #542 .
The exec resource failed when the wazuh-template.json file is not present (bootstrapping).
This failure blocks the template download.
This PR adds the template file to the module.