Skip to content

Conversation

fdalmaup
Copy link
Member

@fdalmaup fdalmaup commented Sep 1, 2025

Description

Closes #31672. Removes Vulnerability Detector integration tests deprecated since Wazuh v4.8.0.

Proposed Changes

  • Remove deprecated VD workflows: 4_testintegration_vulnerability_detector-tier-0-1.yml and 4_testintegration_vulnerability_detector-tier-2.yml
  • Remove deprecated integration tests from tests/integration: complete test_vulnerability_detector folder.

Results and Evidence

Manual tests with their corresponding evidence

  • Compilation without warnings on every supported platform
    • Linux
    • Windows
    • MAC OS X
  • Log syntax and correct language review
  • Memory tests for Linux

    • Coverity
    • Valgrind (memcheck and descriptor leaks check)
    • AddressSanitizer
  • Memory tests for Windows

    • Coverity
    • UMDH
  • Memory tests for macOS

    • Leaks
    • AddressSanitizer
  • Decoder/Rule tests (Wazuh v4.x)

    • Added unit testing files ".ini"
    • runtests.py executed without errors
  • Engine (Wazuh v5.x and above)

    • Test run in parallel
    • ASAN for test (utest/ctest)
    • TSAN for test and wazuh-engine.

Artifacts Affected

Configuration Changes

Tests Introduced

Review Checklist

  • Code changes reviewed
  • Relevant evidence provided
  • Tests cover the new functionality
  • Configuration changes documented
  • Developer documentation reflects the changes
  • Meets requirements and/or definition of done
  • No unresolved dependencies with other issues
  • ...

@fdalmaup fdalmaup requested a review from Copilot September 1, 2025 15:56
@fdalmaup fdalmaup self-assigned this Sep 1, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated Vulnerability Detector integration tests that have been marked as deprecated since Wazuh v4.8.0. The changes systematically delete the entire test_vulnerability_detector folder structure containing legacy VD tests.

  • Complete removal of deprecated vulnerability detector integration test suite
  • Cleanup of associated test data files, configurations, and utilities
  • Removal of deprecated workflow references mentioned in PR description

Reviewed Changes

Copilot reviewed 107 out of 107 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/integration/test_vulnerability_detector/utils.py Removed utility functions for VD test operations
tests/integration/test_vulnerability_detector/test_vulnerability_inventory/ Removed entire vulnerability inventory test suite
tests/integration/test_vulnerability_detector/test_scan_types/ Removed scan type test modules (baseline, full, partial)
tests/integration/test_vulnerability_detector/test_scan_results/ Removed scan result validation test modules
Various YAML files Removed test case configurations and data templates

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove VD deprecated tests
1 participant