Fix cmake error on external misc library #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Linux builds, if strlcpt and strlcat are already provided, cmake is given an empty list of sources to build for the "misc" library. Newer versions of cmake throw an error for this. In this case, we should just avoid building the library. Failure pattern: CMake Error at external/misc/CMakeLists.txt:35 (add_library): No SOURCES given to target: misc CMake Generate step failed. Build files cannot be regenerated correctly. Fixes wb2osz#319
0x1c
approved these changes
Sep 7, 2023
alexf91
added a commit
to alexf91/AUR-PKGBUILDs
that referenced
this pull request
Sep 19, 2023
Temporarily add patch: wb2osz/direwolf#487
archlinux-github
pushed a commit
to archlinux/aur
that referenced
this pull request
Sep 19, 2023
Temporarily add patch: wb2osz/direwolf#487
|
Your change fixes the build for Alpine Linux but breaks Ubuntu and Raspberry Pi. |
Looking at the Ubuntu failure, I think the |
|
Actually the whole |
|
I think I have something that fixes the build on Alpine without breaking the others. |
Sorry for the delay. Looks like this approach works for me! (Clear Linux) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Linux builds, if strlcpt and strlcat are already provided, cmake is given an empty list of sources to build for the "misc" library. Newer versions of cmake throw an error for this. In this case, we should just avoid building the library.
Failure pattern:
CMake Error at external/misc/CMakeLists.txt:35 (add_library):
No SOURCES given to target: misc
CMake Generate step failed. Build files cannot be regenerated correctly.
Fixes #319