Renamed matchbook-types-to-matchbook-messages#39
Renamed matchbook-types-to-matchbook-messages#3996RadhikaJadhav wants to merge 2 commits intowbjohnston:mainfrom
Conversation
wbjohnston
left a comment
wbjohnston
left a comment
There was a problem hiding this comment.
It seems like you created a duplicate of matchbook-types called matchbook-messages in the packages/ directory. I'm still able to compile the project, but thats because everything is still using the old matchbook-types directory. You'll want to remove matchbook-types.
You'll also want to point all dependent services at matchbook-messages. Both the port and matching engine services are dependent. You'll be able to find the import in services/matching-engine/Cargo.toml and services/port/Cargo.toml.
Finally, matchbook-types is a member of the vscode workspace I use to develop the project. Doing a find replace in matchbook.code-workspace s/matchbook-types/matchbook-messages/ would be enough to update that file.
|
If you have trouble with any of this, I'm happy to help 😃 |
|
@96RadhikaJadhav still interested in resolving this issue? |
wbjohnston
added
the
S-waiting-on-author
2 participants
This PR will resolve issue #20 .