Fix filesystem whitelist validation to prevent prefix bypasses#78
Open
zsio wants to merge 1 commit intowbopan:mainfrom
Open
Fix filesystem whitelist validation to prevent prefix bypasses#78zsio wants to merge 1 commit intowbopan:mainfrom
zsio wants to merge 1 commit intowbopan:mainfrom
Conversation
zsio
commented
Sep 21, 2025
zsio
commented
- normalize allowed base paths and ensure target directories stay within them using path.relative
- reject look-alike sibling directories that only share a string prefix with the whitelist
- add unit coverage proving the stricter guard while keeping existing behaviour intact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.