Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #12 - Coral Select with multiple values #13

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Fix for #12 - Coral Select with multiple values #13

merged 4 commits into from
Mar 20, 2024

Conversation

rubnig
Copy link
Contributor

@rubnig rubnig commented Mar 20, 2024

Fixes #12

@rubnig rubnig mentioned this pull request Mar 20, 2024
Closed
@stefanseifert
Copy link
Member

@rubnig thanks for the contribution - looks good, but i think i found a small JS error fixed in 6831bad - please cross-check

@stefanseifert stefanseifert self-assigned this Mar 20, 2024
@rubnig
Copy link
Contributor Author

rubnig commented Mar 20, 2024 •
edited
Loading

This was a typo indeed, thanks for the cross check @stefanseifert!

Tested it and it works fine for me

@stefanseifert stefanseifert merged commit 22ef678 into wcm-io:develop Mar 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stefanseifert stefanseifert

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for showhide functionality for coral-select with multiple selections allowed
2 participants
@rubnig @stefanseifert