improve pro updater

includes/API/Settings.php

@@ -34,6 +34,9 @@ class Settings extends WP_REST_Controller {
 	 */
 	public function __construct() {
 		add_filter( 'option_woocommerce_pos_settings_payment_gateways', array( $this, 'payment_gateways_settings' ) );
+
+		// remove this once Pro settings have been moved to the new settings service.
+		add_filter( 'pre_update_option_woocommerce_pos_pro_settings_license', array( $this, 'remove_license_transient' ) );
 	}
 
 	/**
@@ -543,4 +546,12 @@ public function payment_gateways_settings( $options ) {
 
 		return $options;
 	}
+
+	/**
+	 * Temporary fix for stale license status transient. Remove when possible.
+	 */
+	public function remove_license_transient( $value ) {
+		delete_transient( 'woocommerce_pos_pro_license_status' );
+		return $value;
+	}
 }