ct/reconciler: add retry mechanism for metastore transport errors #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change add_objects, replace_objects, and commit_objects method signatures to take const refs instead of taking unique_ptr by value. This enables retry scenarios where the builder needs to remain usable after the call. The replicated metastore's release method is no longer used and is removed. The simple metastore still uses this method for testing, so it remains.
They aren't needed for metastore add_objects, replace_objects, and commit_objects calls, and are potentially confusing.
…errors Add retry logic to reconciler's metastore add_objects calls to handle transport errors. Previously, the reconciler would immediately fail and abandon the reconciliation round on any metastore error.
wdberkeley
force-pushed
the
retry-builder-metastore
branch
2 times, most recently
from
eebea5e to
7f5a333
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add retry logic to reconciler's metastore add_objects calls to handle transport errors. Previously, the reconciler would immediately fail and abandon the reconciliation round on any metastore error.
Backports Required
Release Notes