My Movie Project #11
Open
My Movie Project #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <h3 id ="error3">Please go back and enter a different movie name.</h3> | ||
| <br><br><br><br><br><br><br> | ||
| <a class ="button" id="second_button" href="/">Go Back</a> | ||
|
|
There was a problem hiding this comment.
I reviewed your app and I don't see too much room for improvement. Which is good. I like your error messages if @movies == nil. I see that you use a lot of
tags. I think that you could accomplish the same thing by using css. You have id tags in each div, so you could assign padding or margin to the top and bottom that could give you the space you want. I think that would be cleaner than all the
tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.