done #9
done #9
Conversation
| <div class="error_pic"> | ||
| <img src="http://2.bp.blogspot.com/-fGs3JIX7Hnc/TnzL6TpzuaI/AAAAAAAAE84/aMZbsoqO9Hk/s1600/thumbsdown.jpg" alt="pic"> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
I like that you have a separate error page for bad input or no input on the movies. I notice that you have a the same search form on several different pages. It is cool from a user perspective that you can search for a new movie wherever you are in the app. From a "DRY" perspective, the code is being repeated. I'm not sure how to DRY it up in Sinatra, but there is definitely a way to do it when we get to rails. They are called "partials". They are little files (partial file) that get included ("rendered") wherever you want.
There was a problem hiding this comment.
O yea ok I see thanks
On Tuesday, April 22, 2014, Spencer Eldred [email protected] wrote:
In views/error.erb:
+
+
<h1> Please Search again! </h1>
+
+
<input type='text' class='form-control' name='movie' placeholder='Movie Title'><button type='submit' class='btn btn-default'>Search</button>+
+
+
+
+I like that you have a separate error page for bad input or no input on
the movies. I notice that you have a the same search form on several
different pages. It is cool from a user perspective that you can search for
a new movie wherever you are in the app. From a "DRY" perspective, the code
is being repeated. I'm not sure how to DRY it up in Sinatra, but there is
definitely a way to do it when we get to rails. They are called "partials".
They are little files (partial file) that get included ("rendered")
wherever you want.—
Reply to this email directly or view it on GitHubhttps://github.com//pull/9/files#r11875501
.
- Stuart Grossman
donsky