Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New frontend look, bugfixes & code cleanup #2

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

rafaelklaessen
Copy link

Frontend

  • New login/account/reset password page look
  • Removed unnecessary files
  • Reorganized files (CSS in CSS folder, JS in JS folder)
  • Used HTML5 & cleaned up JS
  • Fixed ResetPassword.jsp showing a blank page when the resetId is invalid or already used

Backend

  • JSON responses now have a response type of application/json instead of plaintext
  • Improved error messages in error responses
  • Made error & success responses JSON
  • Fixed account bug (see Account fix #1)
  • Fixed /oauth/account/createAccount not validating email address
  • Fixed ApplicationRegistry not checking wether a client_id was already taken (similar to account bug)
  • Fixed /oauth/auth not verifying redirect_uri which could cause a URISyntaxException
  • Fixed NullPointerException in /oauth/resource_query when given access token was present but invalid
  • Removed test code
  • Cleaned up code
  • Updated license year

@Titogelo Titogelo requested a review from stefaanternier May 7, 2017 13:18
@rafaelklaessen
Copy link
Author

Please note that if this PR gets merged #1 isn't required anynore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants