#52 fix: enforce membership check before deleting/updating shared brain #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an authorization bypass vulnerability that allowed any user to delete or update a shared brain by setting
isShare: true
and providing the brain's ID without verifying membership.Vulnerability Details
Previously, the
deleteBrain
function did not confirm that the requesting user was a member of the shared brain. This allowed unauthorized users to perform destructive actions on shared resources.Fix
isShare
is true:ShareBrain
for a matching record of the brain and user.