Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo Heroju -> Heroku #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Typo Heroju -> Heroku #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion the-development-handbook.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ We use pull requests and code reviews for new changes unless we're sure they're
**A note on pull request size:** When developing, we should focus on keeping pull requests small. Smaller pull requests where every code change is in persuit of the same goal are much easier to review than huge ones that change all sorts of things. If you have 5 bugs to fix, raising a pull request for each bug could be an example of this. Generally, however, just consider how you can chunk work down to make code review easier for others.

### Continuous integration
We set up CI on all of our projects, and on all branches. CI should run all of the project tests and linting, and either block deployments or fail pull requests on Github if it doesn't pass. We should consider using [Heroku CI](https://devcenter.heroku.com/articles/heroku-ci) for this if we're deploying to Heroju, but failing that, we've had success with [CircleCI](https://circleci.com) in the past.
We set up CI on all of our projects, and on all branches. CI should run all of the project tests and linting, and either block deployments or fail pull requests on Github if it doesn't pass. We should consider using [Heroku CI](https://devcenter.heroku.com/articles/heroku-ci) for this if we're deploying to Heroku, but failing that, we've had success with [CircleCI](https://circleci.com) in the past.

### Hosting
Unless a client has other hosting arranged, we host most of our projects on [Heroku](http://heroku.com), setting up an [Organisation](https://devcenter.heroku.com/articles/org-users-access) for each client, and using a [Pipeline](https://devcenter.heroku.com/articles/pipelines) to create a staging environment linked to the `staging` branch on Github, and a production environment linked to the `master` branch on Github.
Expand Down