test to validate the class name-algomo-dev crashloop on 363-char clas… #166
Conversation
| } | ||
| client.schema.create_class(class_obj) | ||
| response = client.schema.get(); | ||
| print(response); |
There was a problem hiding this comment.
this print statement can be removed
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
| client.schema.delete_all() | ||
| class_obj = { | ||
| "vectorizer": "none", | ||
| "vectorIndexConfig": { |
There was a problem hiding this comment.
I believe it is not needed when vectorizer is turned off
There was a problem hiding this comment.
Yes. The Default vectorizer is 'none' in docker file. I can remove this line.
| assert (response.status_code == 200) | ||
| return response; | ||
|
|
||
| invalid_long_classname(client) |
There was a problem hiding this comment.
script could be extended to validate property name as well.
property names are used to create directory names, so they may turn up being too long.
| echo "Starting Weaviate with auto-schema enabled..." | ||
| docker-compose -f apps/create-class-validation/docker-compose.yml up -d | ||
|
|
||
| docker run --network host -t create-class-validation python3 invalid_class_long_name.py |
| fi | ||
|
|
||
| echo "Starting Weaviate with auto-schema enabled..." | ||
| docker-compose -f apps/create-class-validation/docker-compose.yml up -d |
There was a problem hiding this comment.
IMO instead of creating new docker compose to change one env variable, existing docker compose could be reused and updated to support new variable apps/weaviate-no-restart-on-crash/docker-compose.yml.
Default value for variable can be set in apps/weaviate-no-restart-on-crash/.env and overwritten when needed directly in command:
AUTOSCHEMA_ENABLED=false docker-compose -f apps/weaviate-no-restart-on-crash/docker-compose.yml up -d
This PR has test for invalid class name creation. There are 2 tests to validate the length of character in the name of a class. One test when 'AUTO-SCHEMA-ENABLED' is true and the other when the 'AUTO-SCHEMA-ENABLED' is false.
Please note: I will have to revist this test when the fix is in place. For now, I am asserting if the status code of the class creation is 200.