Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate sentry (Opt-in, disabled by default) #5221

Open
wants to merge 5 commits into
base: stable/v1.24
Choose a base branch
from

Conversation

etiennedi
Copy link
Member

Changes

  • Optional Sentry support. This is disabled by default. No behavior changes unless Sentry is explicitly activated
  • Right now any caught panic, i.e. all places where we call recover() will also send the panic to Sentry if enabled
  • Non-panic errors are not yet tracked. Here we need to gain some experience of what errors are worth tracking.

Configuration

Env var Default Notes
SENTRY_ENABLED false Overall feature gate. If false, no sentry code will ever be executed.
SENTRY_DSN "" Connection string as defined in the Sentry UI. Required if SENTRY_ENABLED=true
SENTRY_DEBUG false Passed directly to Sentry init func
SENTRY_RELEASE "" Sentry tries to figure out the release on its own, but this will likely not work in Docker. Ideally, here we use K8s magic to always automatically set this to the image tag
SENTRY_TAG_<key> "" Set arbitrary key/value pairs, such as SENTRY_TAG_foo=bar . Must adhere to Sentry tag rules wrt length and allowed chars.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@etiennedi etiennedi marked this pull request as ready for review June 27, 2024 05:46
@aduis aduis requested a review from a team as a code owner June 27, 2024 10:57
Copy link

sonarcloud bot commented Jun 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants