Skip to content

Commit

Permalink
fix: should use dynamic import to import matchRoutes (#6033)
Browse files Browse the repository at this point in the history
  • Loading branch information
yimingjfe committed Aug 2, 2024
1 parent 495d11c commit bc565cd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .changeset/neat-schools-raise.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@modern-js/server-core': patch
---

fix: should use dynamic import to import matchRoutes
fix: 应该使用 动态 import 来引入 matchRoutes
4 changes: 3 additions & 1 deletion packages/server/core/src/plugins/render/render.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import { Logger, Metrics, Reporter, ServerRoute } from '@modern-js/types';
import { cutNameByHyphen } from '@modern-js/utils/universal';
import { TrieRouter } from 'hono/router/trie-router';
import type { Router } from 'hono/router';
import { matchRoutes } from '@modern-js/runtime-utils/router';
import type { Params } from '../../types/requestHandler';
import {
parseQuery,
Expand Down Expand Up @@ -256,6 +255,9 @@ async function renderHandler(
const { nestedRoutesJson } = serverManifest;
const routes = nestedRoutesJson?.[options.routeInfo.entryName!];
if (routes) {
const { matchRoutes } = await import(
'@modern-js/runtime-utils/remix-router'
);
// eslint-disable-next-line node/prefer-global/url
const url = new URL(request.url);
const matchedRoutes = matchRoutes(
Expand Down

0 comments on commit bc565cd

Please sign in to comment.