Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve host resolution and wildcard host handling #4479

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

chenjiahan
Copy link
Member

Summary

This pull request focus on improving hostname resolution and simplifying the codebase. The most important changes include adding a utility function to check for wildcard hosts, refactoring the hostname resolution logic, and updating the usage of these functions in the hmrFallback module.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 771513b
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67a1fdcea5352e0008dee663
😎 Deploy Preview https://deploy-preview-4479--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 67 (🔴 down 16 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@chenjiahan chenjiahan merged commit 12cb066 into main Feb 4, 2025
10 checks passed
@chenjiahan chenjiahan deleted the refactor_host_resolution_0204 branch February 4, 2025 12:00
@chenjiahan chenjiahan mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant