feat(plugin-react): complete preserve React runtime
#6240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rsbuild ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR completes the implementation of the preserve React runtime by configuring the JavaScript parser to support JSX syntax. When using the preserve runtime mode, the parser must be explicitly configured to handle JSX, otherwise it will panic during parsing.
- Added parser configuration to set
javascript.jsxtotruewhenpreserveruntime is used - Added test coverage to verify the parser configuration is correctly applied
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/plugin-react/src/react.ts | Added conditional logic to configure JavaScript parser for JSX when preserve runtime is used |
| packages/plugin-react/tests/index.test.ts | Added test case to verify parser configuration for preserve runtime |
| packages/plugin-react/tests/snapshots/index.test.ts.snap | Added snapshot for the new test case |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
2 tasks
|
Releasing: #6241 |
2 tasks
This was referenced Sep 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the second step after web-infra-dev/rspack#11664.
the JavaScript parser must be set to support
jsxor it will panic in paring JSX syntax.Related Links
Checklist