Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: change to commonjs-static library type of commonjs format #819

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fi3ework
Copy link
Member

@fi3ework fi3ework commented Mar 5, 2025

Summary

commonjs-static will directly skip all unprovided exports, which will lead to lose exports. We need to fix this in webpack / Rspack: add commonjs like runtime code to export dynamically as the fallback of unprovided exports.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Mar 5, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 0c551f9
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67c8523294f00400088c20f8
😎 Deploy Preview https://deploy-preview-819--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant