Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should check lib array non-empty #820

Merged
merged 2 commits into from
Mar 6, 2025
Merged

fix: should check lib array non-empty #820

merged 2 commits into from
Mar 6, 2025

Conversation

Timeless0911
Copy link
Contributor

Summary

lib field is required in Rslib, we should check it is a valid array with at least one element.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Timeless0911 Timeless0911 requested a review from fi3ework March 6, 2025 08:56
@netlify Netlify
Copy link

netlify bot commented Mar 6, 2025

✅ Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 1a607f4
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/67c96329a06507000876c60b
😎 Deploy Preview https://deploy-preview-820--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Timeless0911 Timeless0911 merged commit ffa3c68 into main Mar 6, 2025
14 checks passed
@Timeless0911 Timeless0911 deleted the fix/check-lib-array branch March 6, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fi3ework fi3ework fi3ework approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Timeless0911 @fi3ework