generated from web-infra-dev/napi-template
-
Notifications
You must be signed in to change notification settings - Fork 9
perf: strict lifecycle and reduce allocation #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #106 will improve performances by 24.08%Comparing Summary
Benchmarks breakdown
|
cf8a3eb
to
8b0c8cd
Compare
6aca4ec
to
523b701
Compare
523b701
to
9013073
Compare
8b4734a
to
9648a33
Compare
9648a33
to
1c5e7c2
Compare
2 tasks
ahabhgk
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the lifetimes of
OnSource
,OnChunk
, andOnName
, indicating that the lifetime of the&str
type parameters in their methods is consistent withStreamSource
. This ensures that all intermediate steps for computing the source map can directly hold &str without worrying about it being dropped, thereby reducing memory overhead.