test: align more test cases with webpack #11834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR aligns more test cases with webpack by adding comprehensive test coverage for compiler functionality, watch mode, and plugins, and enhances the test infrastructure to support both development and production modes.
Key Changes:
- Adds multiple new compiler test cases covering watch events, file change detection, and banner plugin functionality
- Introduces development and production mode test runners for better webpack compatibility
- Fixes quote escaping in DefinePlugin configuration to match webpack behavior
Reviewed Changes
Copilot reviewed 14 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/rspack-test/normalCases/parsing/issue-7519/test.config.js | Fixed DefinePlugin quote escaping to use proper string format |
| tests/rspack-test/multiCompilerCases/watch-events.js | Added test for watch-close event in multi-compiler mode |
| tests/rspack-test/compilerCases/watch.js | Added comprehensive watch mode tests for single compilation and invalidation |
| tests/rspack-test/compilerCases/watch-events.js | Added watch-close event test for single compiler |
| tests/rspack-test/compilerCases/watch-detection.js | Added file change detection tests with various timeout scenarios |
| tests/rspack-test/compilerCases/watch-close.js | Added test for multiple watcher close callback handling |
| tests/rspack-test/compilerCases/changes-and-removals.js | Added tests for tracking file modifications and removals |
| tests/rspack-test/compilerCases/banner-plugin.js | Added BannerPlugin tests for asset caching and footer placement |
| tests/rspack-test/Normal-prod.test.js | Added production mode test runner with exclusions |
| tests/rspack-test/Normal-dev.test.js | Added development mode test runner with exclusions |
| packages/rspack-test-tools/src/helper/directory.ts | Fixed path handling for cross-platform exclude pattern matching |
| packages/rspack-test-tools/src/case/normal.ts | Enhanced test infrastructure to support dev/prod mode creation |
| packages/rspack-test-tools/src/case/index.ts | Exported new dev/prod normal case creators |
| packages/rspack-test-tools/etc/test-tools.api.md | Updated API documentation for new case creators |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
📦 Binary Size-limit
🙈 Size remains the same at 47.89MB |
CodSpeed Performance ReportMerging #11834 will not alter performanceComparing Summary
|
hardfist
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
developmentandproductionmode of normal test cases just like webpack.Related links
Checklist