chore: add import_meta_property_in_destructuring parser hook
#12255
+65
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack canceled.
|
Copilot finished reviewing on behalf of
LingyuCoder
November 20, 2025 10:39
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new parser hook import_meta_property_in_destructuring to enable interoperation between the ImportMetaPlugin and NodeStuffPlugin for handling import.meta.filename/dirname in destructuring contexts.
Key Changes
- Introduces a plugin interop hook mechanism to the JavaScript parser trait
- Adds
import_meta_property_in_destructuringmethod to handle special import.meta properties during destructuring - Implements the hook call chain through the plugin drive system
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| crates/rspack_plugin_javascript/src/parser_plugin/trait.rs | Adds the new import_meta_property_in_destructuring trait method with documentation, and imports DestructuringAssignmentProperty type |
| crates/rspack_plugin_javascript/src/parser_plugin/node_stuff_plugin.rs | Implements stub for the new hook method (marked as TODO), and adds necessary import for DestructuringAssignmentProperty |
| crates/rspack_plugin_javascript/src/parser_plugin/import_meta_plugin.rs | Calls the new hook when processing destructuring of import.meta, allowing other plugins to handle specific properties before falling back to default behavior |
| crates/rspack_plugin_javascript/src/parser_plugin/drive.rs | Implements the plugin drive logic to invoke the hook across all registered plugins using SyncBailHook pattern, and adds necessary imports |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
📦 Binary Size-limit
❌ Size increased by 2.25KB from 47.63MB to 47.63MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12255 will not alter performanceComparing Summary
|
Contributor
Author
|
Can this PR meet your needs? @magic-akari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #10573, to support the parsing of
import.meta.filename/dirnamein theNodeStuffPlugin, interop with theImportMetaPluginis required.Since webpack's parser plugins are implemented in the compiler plugins, compilation hooks can be added on the compiler plugin. However, rspack's parser plugins are implemented in javascript parser, and also the compilation id cannot be obtained inside. It needs to be passed in step by step from the outside. Moreover, the processing of the parser and the execution of hooks are synchronous, but on rspack's Rust side, only asynchronous hooks are retained, and synchronous hooks are only privately implemented inside the parser hook.
Therefore, a hook is added to the parser hook for interop between the
ImportMetaPluginand theNodeStuffPlugin, and the name is changed toimport_meta_property_in_desctructuringto indicate that it is a plugin interop hook.Related links
Checklist