Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: support EntryPlugin filename function #6607

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

9aoy
Copy link
Collaborator

@9aoy 9aoy commented May 22, 2024

Summary

Allow EntryPlugin filename configuration to be a function.

fix #5971

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the release: feature release: feature related release(mr only) label May 22, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 0826967
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/664dd5ccb04d350008aa2958
😎 Deploy Preview https://deploy-preview-6607--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

PartialEq = "ignore",
PartialOrd = "ignore",
Ord = "ignore"
)]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahabhgk help~ I'm not sure if ignored is possible here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Hash, PartialEq, Eq, PartialOrd, and Ord traits can potentially be removed now.
These were previously used for testing in Rust.

@9aoy 9aoy changed the title feat: support EntryPlugin filename function WIP: feat: support EntryPlugin filename function May 28, 2024
@github-actions github-actions bot removed the release: feature release: feature related release(mr only) label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error using html-bundler-webpack-plugin
2 participants