Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: set default value of concatenateModules to true in production mode #6959

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

JSerFeng
Copy link
Collaborator

Summary

Set optimization.concatenateModules to true in production mode by default

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 8d57c6b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/667e670a7ebf54000842802f
😎 Deploy Preview https://deploy-preview-6959--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JSerFeng JSerFeng added breaking change release: breaking change release: breaking change related release(mr only) and removed team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Jun 27, 2024
@JSerFeng
Copy link
Collaborator Author

!bench

@rspack-bot
Copy link

rspack-bot commented Jun 27, 2024

📝 Benchmark detail: Open

Name Base (2024-06-26 6b57dd8) Current Change
10000_development-mode + exec 2.26 s ± 27 ms 2.26 s ± 33 ms +0.31 %
10000_development-mode_hmr + exec 744 ms ± 14 ms 744 ms ± 7.1 ms -0.09 %
10000_production-mode + exec 2.81 s ± 19 ms 3.36 s ± 25 ms +19.61 %
arco-pro_development-mode + exec 1.92 s ± 104 ms 1.93 s ± 67 ms +0.88 %
arco-pro_development-mode_hmr + exec 442 ms ± 2 ms 442 ms ± 1.5 ms -0.07 %
arco-pro_production-mode + exec 3.48 s ± 93 ms 4.4 s ± 102 ms +26.62 %
threejs_development-mode_10x + exec 1.61 s ± 17 ms 1.6 s ± 19 ms -0.66 %
threejs_development-mode_10x_hmr + exec 810 ms ± 6 ms 816 ms ± 14 ms +0.75 %
threejs_production-mode_10x + exec 4.91 s ± 33 ms 7.22 s ± 32 ms +47.14 %

Threshold exceeded: ["10000_production-mode + exec","arco-pro_production-mode + exec","threejs_production-mode_10x + exec"]

@JSerFeng
Copy link
Collaborator Author

!eco-ci

@rspack-bot
Copy link

rspack-bot commented Jun 27, 2024

📝 Ran ecosystem CI: Open

suite result
modernjs ❌ failure
nx ❌ failure
rspress ❌ failure
rsbuild ❌ failure
compat ❌ failure
examples ❌ failure

@JSerFeng JSerFeng force-pushed the chore/enable-concatenate-module branch 2 times, most recently from e1ad14d to fce7169 Compare June 27, 2024 11:41
@JSerFeng
Copy link
Collaborator Author

!bench

@rspack-bot
Copy link

⏳ Triggered benchmark: Open

@JSerFeng JSerFeng force-pushed the chore/enable-concatenate-module branch 2 times, most recently from f9da6b8 to fb655d7 Compare June 27, 2024 13:39
@JSerFeng JSerFeng enabled auto-merge (squash) June 27, 2024 13:43
@JSerFeng
Copy link
Collaborator Author

!bench

@rspack-bot
Copy link

rspack-bot commented Jun 27, 2024

📝 Benchmark detail: Open

Name Base (2024-06-26 6b57dd8) Current Change
10000_development-mode + exec 2.26 s ± 27 ms 2.26 s ± 32 ms +0.07 %
10000_development-mode_hmr + exec 744 ms ± 14 ms 735 ms ± 14 ms -1.21 %
10000_production-mode + exec 2.81 s ± 19 ms 3.13 s ± 66 ms +11.52 %
arco-pro_development-mode + exec 1.92 s ± 104 ms 1.93 s ± 72 ms +0.68 %
arco-pro_development-mode_hmr + exec 442 ms ± 2 ms 442 ms ± 2.7 ms -0.16 %
arco-pro_production-mode + exec 3.48 s ± 93 ms 4.3 s ± 100 ms +23.55 %
threejs_development-mode_10x + exec 1.61 s ± 17 ms 1.62 s ± 16 ms +0.24 %
threejs_development-mode_10x_hmr + exec 810 ms ± 6 ms 813 ms ± 6.6 ms +0.27 %
threejs_production-mode_10x + exec 4.91 s ± 33 ms 6.82 s ± 38 ms +39.07 %

Threshold exceeded: ["10000_production-mode + exec","arco-pro_production-mode + exec","threejs_production-mode_10x + exec"]

@hardfist
Copy link
Contributor

the performance regression seems huge

@h-a-n-a h-a-n-a force-pushed the chore/enable-concatenate-module branch from fb655d7 to 8d57c6b Compare June 28, 2024 07:32
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Jun 28, 2024

!bench

@rspack-bot
Copy link

rspack-bot commented Jun 28, 2024

📝 Benchmark detail: Open

Name Base (2024-06-28 940dcb5) Current Change
10000_development-mode + exec 2.26 s ± 23 ms 2.26 s ± 20 ms -0.15 %
10000_development-mode_hmr + exec 742 ms ± 4.2 ms 739 ms ± 18 ms -0.43 %
10000_production-mode + exec 3.14 s ± 20 ms 2.98 s ± 29 ms -4.94 %
arco-pro_development-mode + exec 1.99 s ± 65 ms 1.93 s ± 56 ms -2.77 %
arco-pro_development-mode_hmr + exec 443 ms ± 2.7 ms 442 ms ± 1.1 ms -0.06 %
arco-pro_production-mode + exec 4.07 s ± 95 ms 3.63 s ± 91 ms -10.83 %
threejs_development-mode_10x + exec 1.62 s ± 13 ms 1.62 s ± 19 ms +0.07 %
threejs_development-mode_10x_hmr + exec 816 ms ± 6 ms 817 ms ± 11 ms +0.14 %
threejs_production-mode_10x + exec 5.99 s ± 34 ms 5.85 s ± 38 ms -2.40 %

@JSerFeng JSerFeng merged commit 133e3c9 into main Jun 28, 2024
29 checks passed
@JSerFeng JSerFeng deleted the chore/enable-concatenate-module branch June 28, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change release: breaking change release: breaking change related release(mr only)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants