Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix duplicated harmony exports with named exports and re-exports star #6962

Merged
merged 2 commits into from
Jun 28, 2024
Merged

fix: fix duplicated harmony exports with named exports and re-exports star #6962

merged 2 commits into from
Jun 28, 2024
+27 −12

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Jun 27, 2024 •
edited
Loading

Summary

closes #6934

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Jun 27, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 27, 2024 •
edited
Loading

✅ Deploy Preview for rspack ready!

Name Link
🔨 Latest commit c4dd03e
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/667e41f76dcd210008821ec5
😎 Deploy Preview https://deploy-preview-6962--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@h-a-n-a h-a-n-a marked this pull request as ready for review June 28, 2024 04:57
@h-a-n-a h-a-n-a changed the title fix: fix duplicated harmony exports fix: fix duplicated harmony exports with named exports and reexports Jun 28, 2024
@h-a-n-a h-a-n-a changed the title fix: fix duplicated harmony exports with named exports and reexports fix: fix duplicated harmony exports with named exports and re-exports star Jun 28, 2024
@h-a-n-a h-a-n-a merged commit fda2a66 into main Jun 28, 2024
36 checks passed
@h-a-n-a h-a-n-a deleted the fix/duplicated-exports branch June 28, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahabhgk ahabhgk ahabhgk approved these changes

Assignees

@h-a-n-a h-a-n-a

Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: reexport will have duplicate key in object
2 participants
@h-a-n-a @ahabhgk